ngraham added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in knewfilemenu.cpp:916
> I still think it's better to emit errorMessage instead. Can you check it will 
> be more difficult ?

I don't see how that makes sense. What's wrong with the current approach of 
expecting the jobs themselves to emit errors?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to