ahmadsamir created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ahmadsamir requested review of this revision.
REVISION SUMMARY When a word is added to the dictionary or ignored via the spellingMenu, the BackgroundChecker instance in ontheflycheck should be updated to reflect the changes, otherwise words already added to the dictionary (or ignored) are re-highlited as misspelled when the view changes. Depends on D17629 <https://phabricator.kde.org/D17629>. BUG: 387729 TEST PLAN - Open a file with misspelled words in kate and enable automatic spellchecking - Using the context menu: - add a misspelled word to the dictionary - Ignore another word B misspelling highlighting is removed, as expected - Scroll up/down so that those particular words are out of view then scroll and show them again; notice that those words re-highlighted as misspelled - After applying the pacth, words added/ingored to the dictionary aren't going to be re-highlighted as misspelled when the view changes REPOSITORY R39 KTextEditor BRANCH fix-ontheflycheck-backgroundchecker REVISION DETAIL https://phabricator.kde.org/D17630 AFFECTED FILES src/spellcheck/ontheflycheck.cpp src/spellcheck/ontheflycheck.h src/spellcheck/spellcheck.cpp src/spellcheck/spellcheck.h To: ahmadsamir Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
