zzag added inline comments.
INLINE COMMENTS
> test_xdg_decoration.cpp:178-181
> +
> QTest::addColumn<KWayland::Server::XdgDecorationInterface::Mode>("configuredMode");
> +
> QTest::addColumn<KWayland::Client::XdgDecoration::Mode>("configuredModeExp");
> + QTest::addColumn<KWayland::Client::XdgDecoration::Mode>("setMode");
> +
> QTest::addColumn<KWayland::Server::XdgDecorationInterface::Mode>("setModeExp");
Do we actually use it?
> test_xdg_decoration.cpp:219
> + QVERIFY(shellSurfaceIface);
> + qDebug() << decorationIface->surface();
> + QCOMPARE(decorationIface->surface(), shellSurfaceIface);
Please delete it or provide useful output.
> test_xdg_decoration.cpp:237
> + QVERIFY(modeRequestedSpy.wait());
> + qDebug() << modeRequestedSpy.count();
> + qDebug() << modeRequestedSpy.first().first();
Same here.
> registry.h:665
> + * @see createXdgDecorationManager
> + * @since 5.47
> + **/
since 5.54?
> registry.h:1724
> + /**
> + * Emitted whenever a zxdg_decoration_manger_v1 gets removed.
> + * @param name The name of the removed interface
Typo: manger
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D17498
To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
