jgrulich added inline comments.
INLINE COMMENTS
> dcbsetting.cpp:59
> +
> + for (int i = 0; i < 8; ++i) setPriorityFlowControl(i,
> other->priorityFlowControl(i));
> + for (int i = 0; i < 8; ++i) setPriorityBandwidth(i,
> other->priorityBandwidth(i));
This is odd, maybe we should introduce getters and setters for the whole list,
this would simplify it and you can use it also in fromMap() and toMap()
> dcbsetting.cpp:221
> + } else {
> + return 0;
> + }
Return false.
> dcbsetting.cpp:301
> + } else {
> + return 0;
> + }
Return false.
REVISION DETAIL
https://phabricator.kde.org/D17425
To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
