davidedmundson added a comment.
Code wise:
- Any changes to PlasmaStyle need to happen in the QQC2 (PlasmaComponents3)
version too before shipping
- Please be sure to run qmlscene tests/components/button.qml
- Why do we have nested RowLayouts?
> If we changed that so that buttons could be narrower when the icon + label
is small, than we probably wouldn't need to horizontally center anything.
That's do-able from application space.
Button {
implicitWidth: minimumWidth
}
If you want that, there's no need to change this
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D17355
To: GB_2, #plasma, #vdg
Cc: davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, alexde,
IohannesPetros, trickyricky26, ragreen, Pitel, michaelh, crozbo, ndavis,
ZrenBot, firef, bruns, skadinna, lesliezhai, ali-mohamed, jensreuterberg,
aaronhoneycutt, abetts, sebas, mbohlender, mart
