anthonyfieroni added inline comments.
INLINE COMMENTS
> kemoticonstheme.cpp:32
> ~KEmoticonsThemeData();
> KEmoticonsProvider *provider = nullptr;
> };
Make it shared pointer, KEmoticonsTheme::KEmoticonsTheme(const KEmoticonsTheme
&ket) initialize provider with raw other pointer, deletion will cause a
segfault in use after.
> kemoticonstheme.cpp:41
> {
> -// delete provider;
> + delete provider;
> }
Remove that line.
REPOSITORY
R301 KEmoticons
REVISION DETAIL
https://phabricator.kde.org/D17325
To: kfunk
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
