jgrulich added inline comments. INLINE COMMENTS
> ovspatchsetting.cpp:73 > + } > + > +} Remove this space. > ovspatchsetting.h:29 > + > +#if !NM_CHECK_VERSION(1, 10, 0) > +#define NM_SETTING_OVS_PATCH_SETTING_NAME "ovs-patch" Move this please out of the header file and copy these defines to your test. > ovsportsetting.h:28 > +#if NM_CHECK_VERSION(1, 10, 0) > +#define NM_SETTING_OVS_PORT_SETTING_NAME "ovs-port" > + Same with these defines. Move them ouf of the header. > setting.cpp:129 > typeString = QLatin1String(NM_SETTING_USER_SETTING_NAME); > + break; > case OvsInterface: I already added this missing break when pushing one of your changes. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17252 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns
