bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, mgallien. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision.
REVISION SUMMARY The comparator callback/lambda used a string comparision, which returned the wrong documents, as "2" > "10", and "10" < "9", i.e. selecting the "Highest rating" in dolphin returned all documents with a rating of 2 or higher. Convert the numeric suffix of the rating term ("R2 <https://phabricator.kde.org/source/gcompris/>", "R10 <https://phabricator.kde.org/diffusion/10/>", ...) to an integer value and use it for comparision. BUG: 357960 REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17272 AFFECTED FILES autotests/unit/engine/postingdbtest.cpp src/engine/postingdb.cpp src/engine/postingdb.h src/engine/transaction.cpp src/engine/transaction.h src/lib/searchstore.cpp To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams