jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > iptunnelsetting.h:28 > +#if !NM_CHECK_VERSION(1, 12, 0) > +#define NM_SETTING_IP_TUNNEL_FLAGS "flags" > + No need to define this here, it's already defined in iptunnelsetting.cpp. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17251 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns