pstefan added a comment.
In D15999#368499 <https://phabricator.kde.org/D15999#368499>, @filipf wrote: > In D15999#368498 <https://phabricator.kde.org/D15999#368498>, @ngraham wrote: > > > In D15999#368479 <https://phabricator.kde.org/D15999#368479>, @ndavis wrote: > > > > > It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the `ColorScheme-Text` class and the inner symbols should use the `ColorScheme-Background` class.F6447550: Screenshot_20181129_192418.png <https://phabricator.kde.org/F6447550> > > > > > > The opposite: the background is supposed to be dark with breeze dark, and light with breeze light. > > > In general, with dark themes you want white monochrome icons and the circle is now the dominant icon element, meaning it should get painted white. > > But there is a tangible problem here - imagine what the logout screen when using dark themes would look like if the circles were dark: > > F6447627: image.png <https://phabricator.kde.org/F6447627> > > They would be weird looking and would be superfluous. > > In the case of the SDDM theme I agree it's odd that the circles are colored differently than the input box, but the logout screen is more important. The problem here is, that it's not using a dark color-scheme. The login screen uses a mix of breeze light/dark items. The In D15999#368499 <https://phabricator.kde.org/D15999#368499>, @filipf wrote: > In D15999#368498 <https://phabricator.kde.org/D15999#368498>, @ngraham wrote: > > > In D15999#368479 <https://phabricator.kde.org/D15999#368479>, @ndavis wrote: > > > > > It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the `ColorScheme-Text` class and the inner symbols should use the `ColorScheme-Background` class.F6447550: Screenshot_20181129_192418.png <https://phabricator.kde.org/F6447550> > > > > > > The opposite: the background is supposed to be dark with breeze dark, and light with breeze light. > > > In general, with dark themes you want white monochrome icons and the circle is now the dominant icon element, meaning it should get painted white. > > But there is a tangible problem here - imagine what the logout screen when using dark themes would look like if the circles were dark: > > F6447627: image.png <https://phabricator.kde.org/F6447627> > > They would be weird looking and would be superfluous. > > In the case of the SDDM theme I agree it's odd that the circles are colored differently than the input box, but the logout screen is more important. The problem is that it's not a /dark/ theme. Right now we expect the user to manually change the theme if they do not like the color of the icons. If we'd follow your suggestions the problem would remain, that the white circles would look out of place on light backgrounds. We have no mechanism to adjust the theme based on the wallpaper's lightness automagically right now. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns
