bruns added inline comments.

INLINE COMMENTS

> formatstrings.cpp:81
> +    case 3: string = i18nc("@item:intable image orientation", "180° 
> rotated"); break;
> +    case 4: string = i18nc("@item:intable image orientation", "Vertically 
> flipped"); break;
> +    case 5: string = i18nc("@item:intable image orientation", "Transposed"); 
> break;

Thats somewhat ambigous - flipped along the vertical axis, or top/bottom 
flipped?

> ngraham wrote in formatstrings.cpp:82
> "Transposed" and "Transversed" are very technical terms, and it's hard to 
> understand what they mean in this context. I actually have no idea myself! 
> Could we consider replacing these terms with plainer language?

Thats mirroring/flipping along the diagonals. You get the same effect when you 
mirror vertically and rotate +- 90 degrees.

I don't think there is a less technical term.

> formatstrings.cpp:83
> +    case 5: string = i18nc("@item:intable image orientation", "Transposed"); 
> break;
> +    case 6: string = i18nc("@item:intable image orientation", "90° 
> rotated"); break;
> +    case 7: string = i18nc("@item:intable image orientation", 
> "Transversed"); break;

Clockwise or CCW?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

Reply via email to