loh.tar added a comment.
The added stuff at the ConfigWidget looks to me not perfect but OK. Suggestions are welcome. Some thoughts/questions - Most UI member are named m_foo but some without the m_ prefix. I can't recognize a rule why and chose for my new stuff a name without the prefix due to the way how they are used later, by ui-dot (ui.foo). So my offer is to rename all uniform, let me know which you prefer - The DictionaryComboBox and the new QListWidget (languageList) is somehow reduntant. Would be nice to include the "default language information" into the languageList. But how? The only idea I had was to add an icon to the "default language" by a double click. - Changes at the selected languages appear not direct in the DictionaryComboBox, only at next run. The same rules to the list itself. It would be a little unsettled to reorder the list by each change. - Not investigated if in Settings::setPreferredLanguages is calling d->loader->changed() is needed. Guess it is, but why not in every setFoo function? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar Cc: kde-frameworks-devel, michaelh, ngraham, bruns
