ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Lovely, this is just what I wanted. It's cool that the feature was already
there. :) I like how you preserve the old shortcuts for compatibility. Just a
few changes needed from my perspective:
INLINE COMMENTS
> katepart5ui.rc:2
> <!DOCTYPE gui SYSTEM "kpartgui.dtd">
> <gui name="KatePartView" version="78" translationDomain="ktexteditor5">
> <MenuBar>
You need to bump the version to 79 or else the changes won't take effect.
> kateview.cpp:543
> a = ac->addAction(QStringLiteral("tools_toggle_comment"));
> a->setText(i18n("Toggle Comment"));
> + ac->setDefaultShortcut(a, QKeySequence(Qt::CTRL + Qt::Key_Slash));
Could we also change this string to say "Comment/Uncomment" Rather than "Toggle
comment"? I know that's //technically// correct because this is a toggle
action, but generally one doesn't associate "toggling" things with text editing.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17008
To: slenz, #vdg, ngraham
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, demsking,
cullmann, sars, dhaumann
