On Sunday, November 18, 2018 5:34:02 AM EST Albert Astals Cid wrote: > El dissabte, 17 de novembre de 2018, a les 20:43:04 CET, Noah Davis va escriure: > > On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote: > > > El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va > > > > escriure: > > > > On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote: > > > > > Hi Noah, > > > > > > > > > > At the moment breeze-icons auto tests are failing with this error > > > > > (both > > > > > for > > > > > icons and icons-dark) > > > > > > > > > > The following icons are not available in a scalable directory: > > > > > firewall-applet-shields_up > > > > > firewall-applet-panic > > > > > firewall-applet > > > > > firewall-applet-error > > > > > > > > > > This is because the test makes sure that all icons present in a > > > > > "Fixed > > > > > size > > > > > folder" (for apps 16, 22, 32) should be available in a "Scalable > > > > > size > > > > > folder" (for apps 48). > > > > > > > > > > Could you please work in fixing that so the auto test starts passing > > > > > again? > > > > > > > > > > Cheers, > > > > > > > > > > Albert > > > > > > > > Hi, I was notified about that on the Phabricator diff after it was > > > > landed > > > > (https://phabricator.kde.org/D11880), but I didn't know what the error > > > > meant or what to do about it. I would be glad to fix it if you or > > > > someone > > > > else could help me figure out what to do. > > > > > > I did tell you exactly what is the problem, didn't I? > > > > > > ************* > > > This is because the test makes sure that all icons present in a "Fixed > > > size > > > folder" (for apps 16, 22, 32) should be available in a "Scalable size > > > folder" (for apps 48). > > > ************* > > > > > > Cheers, > > > > > > Albert > > > > I think I just don't understand the system. I think what's tripping me up > > is that some icon themes use a folder called "scalable" for SVGs and the > > other folders are used for PNGs, but Breeze doesn't do that because it > > only uses SVGs and SVGs are naturally scalable. > > I can't give you a definitive answer since i'm not the one that has *any* > idea about breeze icons, but reading the index.theme you can see > > [apps/16] > Size=16 > Type=Fixed > > [apps/32] > Size=32 > Type=Fixed > > [apps/48] > Size=48 > Type=Scalable > > My *guess* is that whoever decided 16, 22 and 32 are "fixed" even if they > are SVG while 48 is not, is that sometimes in the 16, 22, 32 sizes you have > to "sacrifice" some details because since you know it'll be shown in small > sizes it looks better creating a "different" version of the actual icon, > but at 48 they decided "this is going to be good enough so that it'll have > all the details that if you scale it up it'll look good". > > But my guess doesn't matter, what matters is that we have a test that makes > sure that any icon present in apps/16,22,32 should be present in apps/48, > so unless you have a strong reason to dispute the test, you should make it > pass and not fail. > > Cheers, > Albert
I see now, I didn't know about that feature. I guess I just need to symlink firewall-config.svg to firewall-applet.svg and the test will pass. Thanks!
signature.asc
Description: This is a digitally signed message part.
