bruns added inline comments.
INLINE COMMENTS
> embeddedimagedata.cpp:204
> + TagLib::ByteVector pictureData = (*itApe).second.binaryData();
> + int dataPosition = pictureData.find('\0') + 1;
> + return QByteArray(pictureData.data() + dataPosition,
> pictureData.size() - dataPosition);
I know you have only moved this code here ...
`TagLib::ByteVector::find` returns `-1` on not found, and we add 1, so this is
safe here. But maybe we should return `QByteArray()` instead?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16671
To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
