ngraham added a comment.
Uh-oh, now the patch doesn't apply for me anymore:
$ arc patch D16249
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16249.
Checking patch src/core/job_error.cpp...
error: while searching for:
case KIO::ERR_CANNOT_CREATE_SLAVE:
result = i18n("Unable to create io-slave. %1", errorText);
break;
default:
result = i18n("Unknown error code %1\n%2\nPlease send a full bug
report at https://bugs.kde.org.";, errorCode, errorText);
break;
}
error: patch failed: src/core/job_error.cpp:245
Hunk #2 succeeded at 1068 (offset -4 lines).
Checking patch src/core/global.h...
Checking patch src/core/copyjob.cpp...
Applying patch src/core/job_error.cpp with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Applied patch src/core/global.h cleanly.
Applied patch src/core/copyjob.cpp cleanly.
Patch Failed!
Usage Exception: Unable to apply patch!
Might need to be re-based on the current state of master. But you really
should look into using `arc`; it makes all of this so much easier. Setting it
up takes all of 5 minutes. See
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, elvisangelaccio, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
