albertvaka requested changes to this revision.
albertvaka added a comment.
This revision now requires changes to proceed.
In my opinion this is a regression in KIO and it would be nice to check if it
can somehow be fixed there: Upgrading KIO should not break existing apps.
Even if we make a release with this fix, it doesn't guarantee all distros
will pick it up.
INLINE COMMENTS
> kiokdeconnect.cpp:155
> KIO::UDSEntry entry;
> - entry.insert(KIO::UDSEntry::UDS_NAME, QStringLiteral("files"));
> - entry.insert(KIO::UDSEntry::UDS_DISPLAY_NAME, name);
Also don't change insert to fastInsert, as it requires KIO 5.48 and we want to
support older than that.
REPOSITORY
R224 KDE Connect
REVISION DETAIL
https://phabricator.kde.org/D16692
To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: albertvaka, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia,
rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel,
adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC,
menasshock, tctara, apol
