ngraham requested changes to this revision.
ngraham added reviewers: broulik, Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.
Great job, and nice first patch!
Unfortunately, this doesn't compile:
-- Configuring done
CMake Error at src/CMakeLists.txt:32 (add_library):
Cannot find source file:
permeability.cpp
Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
.hxx .in .txx
Looks like the new permeability files weren't added to the patch. You can
use `git add <path to permeability.h> <path to permeability.cpp>` to do so,
then `arc diff` to update the diff.
INLINE COMMENTS
> unit.h:333
> + MiliDarcy,
> + PermeabilitySquareMicrometer
> };
Can you add `/** @since 5.53 */` for each of these new entries, following the
pattern?
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D16681
To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
