bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > office2007extractortest.cpp:52 > QCOMPARE(result.properties().value(Property::Language), > QVariant(QStringLiteral("en-US"))); > + QCOMPARE(result.properties().value(Property::PageCount), QVariant(1)); > + QCOMPARE(result.properties().value(Property::WordCount), QVariant(4)); Strictly speaking, this should be part of another commit. Feel free to split it off and git push without review. REPOSITORY R286 KFileMetaData BRANCH description_dc REVISION DETAIL https://phabricator.kde.org/D12114 To: astippich, #baloo, #frameworks, bruns Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams