bruns added a comment.
In D16643#353672 <https://phabricator.kde.org/D16643#353672>, @trmdi wrote: > In D16643#353670 <https://phabricator.kde.org/D16643#353670>, @bruns wrote: > > > This is not covered by your summary - you have only listed cases where the drag is erroneously **not** accepted. Please update the summary. > > > I wrote it in the first line: > > > m_enabled could change while moving. You made the summary worse ... `m_enabled` may change between //consecutive// DragMove events, but not during an event. In this case, though, it does not, and is constantly true. You can verify this by attaching a debugger or by adding debug statements. The only wrong code part is the `setAccepted(false)`, which should be `setAccepted(true)` (or just `accept()`, both are equivalent). REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh
