astippich added a comment.
In D16490#351799 <https://phabricator.kde.org/D16490#351799>, @bruns wrote: > In D16490#351662 <https://phabricator.kde.org/D16490#351662>, @astippich wrote: > > > Only one minor thing: please also check that the mimetype is in the list of supported mimetypes > > > This can actually happen and is completely valid, due to mimetype inheritance. > > So the check would be `for supported in supportedMimetypes { if QMimeType(input->mimeType()).inherits(supported) return true; }; return false`. But this is already done from the calling code ... Hmmm, I don't understand. When I change the code to return an empty stringlist of supported mimetypes for the xmlextractor, the tests still pass. This should imho be covered by the tests. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
