astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed.
The ape tag tests fail with this patch, but the test is actually wrong in that regard. It tests for an empty disc number, which I haven't noticed before. I've found references to both DISCNUMBER and DISC, so the safest way is probably to check both. So please query both tags like it is already done for the album artist and adjust the taglibextractortest. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd, astippich Cc: astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, spoorun, ngraham, bruns, abrahams
