sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision.
REVISION SUMMARY This elevates a problem with newer SMB protocol versions and smbclient not supporting discovery/browsing. when not using older (as in: ancient) protocol versions discovery doesn't work and smb:/ gives no results. By falling back to DNSSD based discovery we can ensure discovery of DNSSD remotes (namely linux and osx) is always working. Windows unfortunately does not support DNSSD and as such will not benefit from this mode of discovery and continue to be unlisted when using a protocol version without browsing support. CCBUG: 392447 CCBUG: 390551 TEST PLAN smb.conf: [global] client min protocol = SMB2 Lists devices REPOSITORY R320 KIO Extras BRANCH smb-discovery REVISION DETAIL https://phabricator.kde.org/D16299 AFFECTED FILES smb/CMakeLists.txt smb/kio_smb.h smb/kio_smb_browse.cpp To: sitter Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp