bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> embeddedimagedatatest.cpp:48
> +    testAudioFile = testFilePath("test.opus");
> +    
> QCOMPARE(imageData.readMimetypes().contains(mimeDb.mimeTypeForFile(testAudioFile).name()),true);
> +    images = imageData.imageData(testAudioFile);

QVERIFY(condition)

> embeddedimagedata.cpp:73
>  
> +QStringList EmbeddedImageData::readMimetypes() const
> +{

`supportedMimeTypes()` ?
capital `T`, see `ImageType` and `QMimeType`

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16197

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Reply via email to