ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
Thanks for this patch! There are a few things: 1. Let's check for this condition before doing a check for whether there's enough free space on the disk, or else it will report a less-useful error message first (people could go try to make some space, only to discover that the filesystem doesn't even support copying a file that big) 2. `ERR_DISK_FULL` will not display an accurate error message. Perhaps we should define a new type of error message in `src/core/job_error.cpp` to handle this. Something like `ERR_TOO_LARGE_FOR_FAT32` that has an appropriate error message; something like "The file <file> cannot be transferred because it is greater than 4 Gb in size, and the destination's filesystem does not support files that large." 3. There's a `TODO` in this file about implementing this; please remove it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
