dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> qca_basic.h:1081
>
> +class QCA_EXPORT HKDF : public Algorithm
> +{
Missing class documentation.
Missing \since tag.
> qca-botan.cpp:234
> +public:
> + BotanHKDFContext( const QString &hashName, QCA::Provider *p, const
> QString &type) : QCA::HKDFContext(p, type)
> + {
remove space after '('
> qca-botan.cpp:250
> +
> + Context *clone() const
> + {
override?
> qca-botan.cpp:261
> + m_hkdf->kdf(key.data(), keyLength, (const Botan::byte*)secret.data(),
> secret.size(),
> + (const Botan::byte*)salt.data(), salt.size(), (const
> Botan::byte*)info.data(), info.size());
> + QCA::SecureArray retval(QByteArray((const char*)key.data(),
> key.size()));
I'm allergic to C casts, after seeing them misused. Would static_cast work
here? Otherwise reinterpret_cast?
REPOSITORY
R486 QCA Library
REVISION DETAIL
https://phabricator.kde.org/D15510
To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure
