akrutzler updated this revision to Diff 42685.
akrutzler marked 5 inline comments as done.
akrutzler added a comment.
- Use QString() directly instead of QStringLiteral("")
- Use explicit specifier
- Call either finished or error in slave methods
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15277?vs=42450&id=42685
BRANCH
mtp_next
REVISION DETAIL
https://phabricator.kde.org/D15277
AFFECTED FILES
mtp/CMakeLists.txt
mtp/devicecache.cpp
mtp/devicecache.h
mtp/filecache.cpp
mtp/filecache.h
mtp/kio_mtp.cpp
mtp/kio_mtp.h
mtp/kio_mtp_helpers.cpp
mtp/kio_mtp_helpers.h
mtp/kiod_module/CMakeLists.txt
mtp/kiod_module/kmtpd.cpp
mtp/kiod_module/kmtpd.h
mtp/kiod_module/kmtpd.json
mtp/kiod_module/mtpdevice.cpp
mtp/kiod_module/mtpdevice.h
mtp/kiod_module/mtpstorage.cpp
mtp/kiod_module/mtpstorage.h
mtp/shared/CMakeLists.txt
mtp/shared/kmtpdeviceinterface.cpp
mtp/shared/kmtpdeviceinterface.h
mtp/shared/kmtpdinterface.cpp
mtp/shared/kmtpdinterface.h
mtp/shared/kmtpfile.cpp
mtp/shared/kmtpfile.h
mtp/shared/kmtpstorageinterface.cpp
mtp/shared/kmtpstorageinterface.h
mtp/shared/org.kde.kmtp.daemon.xml
mtp/shared/org.kde.kmtp.device.xml
mtp/shared/org.kde.kmtp.storage.xml
To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
