bruns added a comment.
The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit message. INLINE COMMENTS > kwalletd.cpp:685 > + const auto errorStr = > KWallet::Backend::openRCToString(rc); > + qCWarning(KWALLETD_LOG) << "Failed to open > wallet " << wallet << errorStr; > kpd->setPrompt(i18n( nitpick - `qCWarning(..)` add spaces between arguments by default, so there is a double space between "wallet" and <wallet> REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: bruns, mlaurent, kde-frameworks-devel, michaelh, ngraham
