drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed.
Looks good apart from the coding style. Also it would be great to have at least basic autotest. INLINE COMMENTS > media.h:95 > + > + friend class MediaPrivate; > +}; Not needed > media_p.h:42 > + > + Media *q; > + BluezMedia *m_bluezMedia; `= nullptr` > media_p.h:43 > + Media *q; > + BluezMedia *m_bluezMedia; > +}; Same as above > mediaendpoint.h:83 > + */ > + virtual void setConfiguration(const QString& transportObjectPath, const > QVariantMap& properties); > + Coding style: `const QString &transportObjectPath` Please change everywhere > mediaendpoint.h:114 > +private: > + friend class Media; > +}; Not needed > mediaendpoint_p.h:37 > + > +} // namepsace BluezQt > + typo "namepsace" -> "namespace" REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, michaelh, ngraham, bruns
