ltoscano requested changes to this revision. ltoscano added a comment.
I agree with all the objections raised so far, and I'm not sure about the rationale of this change. I'd like to add one point: In D15718#330844 <https://phabricator.kde.org/D15718#330844>, @smithjd wrote: > In D15718#330836 <https://phabricator.kde.org/D15718#330836>, @ngraham wrote: > > > Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless. > > > A default mask of 0002 or more permissive looks fairly common across distros, and is permissive enough to index files by default. No, because even if the default umask is 002, or 022, POSIX says that the default permissions of a file on creation are going to be 0666, not 0777: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap01.html#tag_17_01_01_04 So not only file downloaded by browsers won't have the executable bit, but *every* file on the system. Let's leave the executable bit on files to scripts and other real programs. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
