bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision.
REVISION SUMMARY Although KDE_INSTALL_PYTHONBINDINGSDIR follows the the standard pattern of KDE_INSTALL_<dir> for installation directories, it is not included in the set of directories set by KDEInstallDirs.cmake. INSTALL_DIR_SUFFIX does not specify a path but just a suffix and defaults to "site-packages", i.e. the suffix used by some (but not all) distros. Removing the (typically empty) optional argument from the function invocation avoids confusion and allows to remove the parameter. TEST PLAN make REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D15558 AFFECTED FILES src/lib/CMakeLists.txt To: bruns, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns