lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM.
INLINE COMMENTS
> sip_generator.py:752
> #
> - return "".join(extract).replace("\n", " ")
> + return b''.join(extract).decode('utf-8').replace("\r\n", "
> ").replace("\n", " ").replace("\r", " ")
>
Perhaps mention in the comment that you're doing this for all the types of
newlines?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15068
To: bruns, #frameworks, lbeltrame
Cc: lbeltrame, bcooksley, jtamate, kde-frameworks-devel, kde-buildsystem,
michaelh, ngraham, bruns
