bruns added inline comments.

INLINE COMMENTS

> indexcleaner.cpp:76
>  
> -    const auto includeFolders = m_config->includeFolders();
> -    for (const QString& folder : includeFolders) {
> -        quint64 id = filePathToId(QFile::encodeName(folder));
> -        tr.removeRecursively(id, shouldDelete);
> +    for (const auto& device: m_config->storageDevices()->allMedia()) {
> +        if (!device.isMounted()) {

Undesired detach

> indexcleaner.cpp:82
> +
> +            for (const QString& folder : m_config->includeFolders()) {
> +                if (folder.startsWith(devicePath)) {

Undesired detach

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11529

To: smithjd, #baloo, vhanda, michaelh, broulik
Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

Reply via email to