broulik added inline comments.
INLINE COMMENTS
> kpropertiesdialog.cpp:1161
>
> + l = new QLabel(i18n("File system:"), d->m_frame);
> + grid->addWidget(l, curRow, 0, Qt::AlignRight);
Captailize: File System
> kpropertiesdialog.cpp:1164
> +
> + QStorageInfo *fileSystem = new QStorageInfo(QLatin1String("/"));
> +
This leaks, you can probably create it on the stack:
QStorageInfo storageInfo(...);
Also, shouldn't you pass `url.toLocalFile()` instead of hardcoded `/`?
Also, move it in the `isLocal` check as `QStorageInfo` can only work on paths,
not URLs.
Also, what about `KMountPoint::mountType()`?
> kpropertiesdialog.cpp:1169
> + l->setTextInteractionFlags(Qt::TextSelectableByMouse |
> Qt::TextSelectableByKeyboard);
> + l->setText(QString(fileSystem->fileSystemType()));
> +
`QString::fromLatin1`?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15000
To: shubham, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
