adridg added a comment.
Without patch, all tests ======================== Totals: 44 passed, 2 failed, 0 skipped, 0 blacklisted, 225ms The two failed tests are: - testThreads - testDelete With patch, all tests ===================== Totals: 45 passed, 1 failed, 0 skipped, 0 blacklisted, 229ms The one failed test is: - testDefaults Without patch, some tests ========================= Some tests means run `HOME=/tmp/drop bin/kconfigtest testDelete testThreads testDefaults` ********* Start testing of KConfigTest ********* Config: Using QtTest library 5.10.1, Qt 5.10.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 5.0.0 (tags/RELEASE_500/final 312559)) PASS : KConfigTest::initTestCase() FAIL! : KConfigTest::testDelete() '!delgr.exists()' returned FALSE. () Loc: [/home/adridg/src/kde/tier-1/kconfig/autotests/kconfigtest.cpp(802)] PASS : KConfigTest::testThreads() FAIL! : KConfigTest::testDefaults() Compared values are not the same Actual (group.readEntry("entry1", QString())): "hello" Expected (Default) : "Default" Loc: [/home/adridg/src/kde/tier-1/kconfig/autotests/kconfigtest.cpp(399)] PASS : KConfigTest::cleanupTestCase() Without patch, some tests ========================= ********* Start testing of KConfigTest ********* Config: Using QtTest library 5.10.1, Qt 5.10.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 5.0.0 (tags/RELEASE_500/final 312559)) PASS : KConfigTest::initTestCase() PASS : KConfigTest::testDelete() FAIL! : KConfigTest::testThreads() Compared values are not the same Actual (group.readEntry("entry1", QString())): "hello" Expected (Default) : "Default" Loc: [/zbigone/src/kde/tier-1/kconfig/autotests/kconfigtest.cpp(399)] PASS : KConfigTest::testDefaults() PASS : KConfigTest::cleanupTestCase() Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted, 41ms ********* Finished testing of KConfigTest ********* REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14927 To: dfaure, adridg, arichardson Cc: kde-frameworks-devel, michaelh, ngraham, bruns