dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
And yes this needs a license, obviously. If the original author(s) can't be reached anymore, that means rewriting the example :( INLINE COMMENTS > CMakeLists.txt:3 > + > +find_package(ECM NO_MODULE) > +find_package(Qt5Widgets) CONFIG looks less negative than the old "NO_MODULE" > dialog.cpp:33 > + layout()->addWidget(explanation); > + qobject_cast<QVBoxLayout*>(layout())->addStretch(); > + layout()->addWidget(m_statusLabel); Urgh, better have a QVBoxLayout* local variable. > dialog.cpp:41 > + > + connect(m_launchButton, SIGNAL(clicked()), SLOT(doSave())); > + new-style connect would be better > dialog.h:16 > +public: > + Dialog(QWidget *parent = 0); > + nullptr REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
