dhaumann added a comment.
Looks ok to me. Only thing is: with takeLast() you now changed the order of the IncludedDefinitions compared to the previous version. This is of course ok, but in the color config dialog the order is now different than before. Whatever this means... I liked that Modelines and Alert were rather late in the list - on the other hand that was not guaranteed before either... ;) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14952 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
