dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kdirlistertest.cpp:530
> + const QMimeType htmlType =
> db.mimeTypeForUrl(QUrl(QLatin1String("file:///index.html")));
> + qDebug() << "html mimeType=" << htmlType;
> +
Should be removed -- or QCOMPAREd.
> kdirlistertest.cpp:926
> dirLister.openUrl(QUrl::fromLocalFile(path));
> - QVERIFY(spyCompleted.wait(1000));
> - QVERIFY(spyCompleted.wait(1000));
We no longer verify that completed is emitted twice...
> kdirlistertest.cpp:963
> QSignalSpy spyCompleted(&secondDirLister, SIGNAL(completed()));
> - QVERIFY(spyCompleted.wait(1000));
> - QVERIFY(secondDirLister.isFinished());
why was this removed?
> kdirlistertest.cpp:1107
> QSignalSpy spyCompleted(&m_dirLister, SIGNAL(completed()));
> - QVERIFY(spyCompleted.wait(1000));
> - QVERIFY(m_dirLister.isFinished());
same here and elsewhere
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11604
To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns
