dfaure added a comment.
I don't understand your question. By "this", do you mean the KMainWindow fix that was posted in a previous iteration here and that was pushed? That one is very much needed, yes, to make setAutoSaveSettings work. The change that you link to, is about porting KMail to setAutoSaveSettings, so that it benefits from that fix. If by "this" you mean what's left in this review request, which is to write a proper unittest for the KMainWindow fix, yes, that would still be very nice to have. But apparently it's pretty hard to write (if emulating native events is the only way then indeed it seems really difficult)... so maybe we have to give up on the idea. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
