dhaumann added a comment.
Just curious: The test file looks good to me, but it looks to me that it also contains some redundancy: Think of it as follows: We use this for unit testing. As such, the best case is that a test file tests all the corner cases, but ideally only once. If a test fails, then we get a diff with the changed highlighting information. And if the file is 400 lines of code, checking for regressions is much more work compared to if the file only contains e.g. 50 lines. So: would it be possible to strip it down a bit? And also: Is this file freely usable, e.g. licensed under MIT? Would be nice to add a license comment in the first line. REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
