dfaure created this revision.
dfaure added reviewers: apol, mpyne, davidedmundson, arichardson.
Restricted Application added a project: Frameworks.
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
dfaure requested review of this revision.
REVISION SUMMARY
As a fallback when the property type is unknown, we use string.
When reading a stringlist, if the key is absent or empty, this method
was returning QStringList(""), which was rather unexpected.
TEST PLAN
XDG_DATA_DIRS='foo' ../bin/kplugininfotest in kservice:
Got dependencies ("")
FAIL! : KPluginInfoTest::testLoadDesktop(from KService::Ptr) Compared lists
have different sizes.
Actual (info.dependencies()) size: 1
Expected (QStringList()) size: 0
REPOSITORY
R244 KCoreAddons
BRANCH
convert_empty_string_to_stringlist
REVISION DETAIL
https://phabricator.kde.org/D14722
AFFECTED FILES
src/lib/plugin/kpluginmetadata.cpp
To: dfaure, apol, mpyne, davidedmundson, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
