rjvbb abandoned this revision.
rjvbb added a comment.

  I'm abandoning this for now because my assumption was wrong even though my 
patch had the effect I intended. I'll reopen if/when I have a real fix, because 
there are still 2 issues here:
  
  - The inappropriate warning. This could be fixed by a version of my current 
patch or else by rewording the warning.
  - The somewhat unorthodox way of coredumping. `/proc/sys/kernel/core_pattern` 
is Linux-specific but the `coredumpsize` "limit" shell setting exits on other 
Unix variants too. IOW, an absent or empty core_pattern file doesn't guarantee 
that a core dump will NOT be created when the caught signal is re-raised. In 
addition, that core_pattern may be set to a crash-reporter facility (apport in 
my case) which is completely irrelevant for code that wasn't installed through 
an official distribution package (the case for all my Qt5/KF5 software).
  
  In short, I think that what's needed here is a configuration variable rather 
than a check of the core_pattern special file (but that file could be used to 
provide the initial value of the config setting).

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D14606

To: rjvbb, #frameworks, sitter
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to