rjvbb created this revision. rjvbb added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rjvbb requested review of this revision.
REVISION SUMMARY This patch addresses a minor detail that has been irking me for a while now: the message that DrKonqi couldn't be started after the user closed that very application without filing a report. The warning message is wrong, for evident reasons, but I think there is also no need to re-raise the signal for core-dump processing in this case. After all, the user has had all the opportunity to investigate the backtrace or even connect a debugger "manually" to the crashed process. TEST PLAN start any KF5 application and send it signal like SIGSEGV. Close DrKonqi after it appeared. - without the patch: KCrash claims it was unable to start DrKonqi and re-raises the signal - with the patch: no such claim, and no core-dump (or expensive apport processing on Ubuntu) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D14606 AFFECTED FILES src/kcrash.cpp To: rjvbb, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
