dfaure added inline comments. INLINE COMMENTS
> anthonyfieroni wrote in kfileplaceeditdialog.cpp:220 > This will produce error on strict level it should be > > m_iconButton != nullptr Which strict level is that? AFAIK it's perfectly valid to "cast" a pointer into a boolean, we do this *everywhere*... > kfileplaceeditdialog.h:120 > + * @returns whether the item's icon is editable, beacause all icons are > not > + * (e.g. the Trash can display two icons, representing it's full and > empty states > + * it's simpler to make these icons non-editable than to provide an > interface to edit them both) it's => its REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: dfaure, anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns
