apol added a comment.
:( please @broulik INLINE COMMENTS > rjvbb wrote in CMakeLists.txt:77 > Preferred choice on Linux and other non-Mac Unix variants (or even only Linux > because as mentioned earlier, libcanberra is only tested there). It can't be > the preferred choice when no native backend is available, IMHO. > > Wouldn't the cleanest way to achieve that be the use of a `USE_CANBERRA` > CMake option that defaults to `ON` on platforms where the dependency can be > expected? Then you can make both backends hard dependencies. I'd say this is perfectly fine, already not optional. If you want to disable it, pass `-DCMAKE_DISABLE_FIND_PACKAGE_Canberra=OFF`. I really don't see what the big fuss is all about. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb Cc: apol, cfeck, alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns
