ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
This works and doesn't crash Gwenview for me anymore, yay! Please fix the below issues. And @pino, does the code look sensible now? INLINE COMMENTS > kfileplaceeditdialog.h:124 > bool applicationLocal() const; > + > + /** Remove the extra four spaces on this line please > kfileplaceeditdialog.h:127 > + * @returns check for icon's editabilty > + */ > + bool canEditIcon() const; This is a public function so please add `@since 5.49` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
