mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > ktimecomboboxtest.cpp:198 > + QString mask = m_combo->lineEdit()->inputMask(); > + QCOMPARE(mask.contains(QLatin1String("aa")), true); > + delete m_combo; Could you provide another case where mask will not contains "aa" so we can be sure that code works Thanks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14435 To: glennw, cfeck, mlaurent Cc: ngraham, kde-frameworks-devel, michaelh, bruns