pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.
It is a good start, but not enough:
- `m_iconButton` must be set to null in the constructor (ideally at the
beginning, in the initializer list), otherwise it will be uninitialized memory
- `KFilePlaceEditDialog::icon()` will crash now, so its usage of
`m_iconButton` must be guarded; either you return the icon passed to the
constructor (which thus you need to save), or adjust callers to ask whether the
icon could be changed, and only in that case get the icon
INLINE COMMENTS
> kfileplaceeditdialog.cpp:123
> +
> + // Draw the icon button for the entry only if it's *NOT* TRASH
> + if (url.scheme() != QLatin1String("trash")) {
No need to SCREAM in comments :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
