markg added a comment.
In D13814#290512 <https://phabricator.kde.org/D13814#290512>, @bruns wrote: > The code looks fine now, but the summary is incorrect. > > The savings is not from using a lambda, but caused by initializing it once. If the old code had used `m_collator(other.m_collator)` in the copy constructor, construction would have been just a ref count increment and each of the following `m_collator.setFoo(...)` would have been noops (QCollator checks if the new value is different to its current value). > > Of course this would have triggered the QCollator bug as well. Is there even a need to have n QCollator objects? I'm talking about a QCollator _within_ a given view. Each view could obviously have it's own collator due to different view settings. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
