zzag added inline comments. INLINE COMMENTS
> pluginloader.cpp:194-196 > + const QString pluginName = name.section(QLatin1Char('/'), -1); > > + QVector<KPluginMetaData> plugins; Nitpick: IMHO, it would be better to move these two down (right before `if (useRuntimeCache) {`). So, cache invalidation and cache population stuff goes first, then querying stuff. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14009 To: broulik, #plasma, davidedmundson, mart Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns